Not possible to override mappingFallback in VSF 1.11

[juho-jaakkola]

Current behavior

In VSF 1.10 I was able to do this:

In src/modules/index.ts:

import { extendModule } from '@vue-storefront/core/lib/module'
import { urlExtend } from './my-module'

extendModule(urlExtend)

and in my-module:

const extendUrlVuex = {
  actions: {
    async mappingFallback ({ dispatch }, payload: { url: string, params: any}) {
      // Custom check, whether the URL path matches a custom content type.

      return {
        name: 'foo',
        params: {
          slug: 'foo'
        }
      }
    }
  }
}

export const urlExtend = {
  key: 'url',
  store: { modules: [{ key: 'url', module: extendUrlVuex }] },
}

As documented here: https://docs.vuestorefront.io/guide/basics/url.html#how-to-customize-the-mapping-mechanism

However, it seems in 1.11.0 the custom mappingFallback does not get called anymore.

Expected behavior

I should be able to override the default mappingFallback action from my module.

Repository

https://github.com/DivanteLtd/vue-storefront/tree/v1.11.0-rc.2

Can you handle fixing this bug by yourself?

• YES
• NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

• This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
• This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
• This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

[pkarw]

OK, we must check it

[andrzejewsky]

@juho-jaakkola you can still extend modules. Look at this line: https://github.com/DivanteLtd/vue-storefront/blob/v1.11.0-rc.2/src/themes/default/index.js#L22 you can override / extend any module you want. However, @pkarw I think we have to update docs about that because extendModule no longer exist

[pkarw]

good point @andrzejewsky; @kkdg can you please update the docs - about the module extendibility (the change has been implemented to the 1.11 - the modules api changed)

[juho-jaakkola]

I tried the approach @andrzejewsky mentioned, but my custom mapping still does not get called. I'm pretty sure something is still broken in 1.11.

Could you please test whether you are able to override the default mappingFallback action with a custom one?

[andrzejewsky]

@juho-jaakkola look at that diff: https://github.com/DivanteLtd/vue-storefront/compare/release/v1.11...andrzejewsky:extendingModuleExample?expand=1
I'm extending here (as example) registerMapping:

[juho-jaakkola]

I do not fully understand how the routing and url mapping works, but I think the difference is that in 1.10 the whole mappingFallback action got overridden by my custom module, whereas in 1.11 all registered mappingFallback actions get called.

So even if my module returns a matching route, the mappingFallback of the bundled url module will still get called which (apparently?) results in an error.