-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Milestone
Description
Current behavior
Running npx eslint --ext .js,.vue,.ts core src --fix produces warnings in core.
183:14 warning 'localizedRoutePath' was used before it was defined @typescript-eslint/no-use-before-define
185:12 warning 'localizedRouteConfig' was used before it was defined @typescript-eslint/no-use-before-define
195:43 warning 'localizedRouteConfig' was used before it was defined @typescript-eslint/no-use-before-define
217:19 warning 'localizedRoutePath' was used before it was defined @typescript-eslint/no-use-before-define
11:11 warning Interface 'beforeCacheInvalidatedParamter' must be PascalCased @typescript-eslint/class-name-casing
Expected behavior
No Warning
Steps to reproduce the issue
- Open vue-storefront repository in terminal
- Run
npx eslint --ext .js,.vue,.ts core src --fix
Can you handle fixing this bug by yourself?
- YES
- NO
Which Release Cycle state this refers to? Info for developer.
Pick one option.
- This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from
developbranch and create Pull Request2. Feature / Improvementback todevelop. - This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from
releasebranch and create Pull Request3. Stabilisation fixback torelease. - This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from
hotfixormasterbranch and create Pull Request4. Hotfixback tohotfix.
Environment details
- Browser:
- OS: Ubuntu 19.10
- Node: v10.15.2
- Code Version: master