Skip to content

Allow optimising checkout request even if entity optimization is not enabled #4198

@juho-jaakkola

Description

@juho-jaakkola

Current behavior

VSF has two configuration entries related to optimising (reducing) the data in the product entities:

  • entities.optimize
    • Limit the amount of attributes that get loaded from ES
  • entities.optimizeShoppingCart
    • Limit the attributes that get included in the request when doing a checkout

Currently the latter can be used only if the first one is also enabled. See: c10910e#diff-0ea097d7f413c052b03047909d3162a5R7

IMO this is a bug. I don't see a reason why the cart could not be optimised unless the ES queries are also optimised.

Or am I possibly missing something?

Repository

https://github.com/DivanteLtd/vue-storefront/blob/v1.11.2/core/modules/cart/helpers/optimizeProduct.ts#L7

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4: Nice to havePriority mark - it's nice to havebugBug reports

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions