-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Webpack config improvements #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DavidRouyer could You please check the build error - https://travis-ci.org/DivanteLtd/vue-storefront/jobs/387045204 |
I've add Edmonds commerce, KT.Team, Vendic.nl
|
It seems the config.json file is not generated in core/build :/ |
|
Ok, I’ll check it and merge in after you fix the issue with generating build/config.json (however I don’t see at first glance how these changes could broke it :)). For sure these changes are a way to go |
|
ElasticSearch is used just in the core/lib/search.js and we’re using very basic stuff - just sending out the query/getting back the results. As we’re using bodybuilder to create elastic query (https://bodybuilder.js.org/docs/) You can probably just remove the ElasticSearch and user fetch() instead |
|
@DavidRouyer how the things are going with this task? ;) |
|
I fixed the issue with the config.json, it should be good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidRouyer can you change the target branch to develop? We are updating master only once a month with release of new version
Also there were some changes in webpack config recently in Service Workers file that are not compatible with your code. It should be straightforward to adjust your changes and we can merge this PR in ;>
No description provided.