Skip to content

Conversation

@DavidRouyer
Copy link
Contributor

@DavidRouyer DavidRouyer commented Jun 2, 2018

No description provided.

@pkarw
Copy link
Collaborator

pkarw commented Jun 6, 2018

@DavidRouyer could You please check the build error - https://travis-ci.org/DivanteLtd/vue-storefront/jobs/387045204
?

@DavidRouyer
Copy link
Contributor Author

DavidRouyer commented Jun 6, 2018

It seems the config.json file is not generated in core/build :/

@pkarw
Copy link
Collaborator

pkarw commented Jun 8, 2018

Ok, I’ll check it and merge in after you fix the issue with generating build/config.json (however I don’t see at first glance how these changes could broke it :)). For sure these changes are a way to go

@pkarw
Copy link
Collaborator

pkarw commented Jun 14, 2018

ElasticSearch is used just in the core/lib/search.js and we’re using very basic stuff - just sending out the query/getting back the results. As we’re using bodybuilder to create elastic query (https://bodybuilder.js.org/docs/) You can probably just remove the ElasticSearch and user fetch() instead

@filrak
Copy link
Collaborator

filrak commented Jun 18, 2018

@DavidRouyer how the things are going with this task? ;)

@filrak filrak added this to the 1.1 milestone Jun 18, 2018
@DavidRouyer
Copy link
Contributor Author

I fixed the issue with the config.json, it should be good to go :)

@filrak filrak self-requested a review June 20, 2018 19:49
Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidRouyer can you change the target branch to develop? We are updating master only once a month with release of new version

Also there were some changes in webpack config recently in Service Workers file that are not compatible with your code. It should be straightforward to adjust your changes and we can merge this PR in ;>

@DavidRouyer DavidRouyer changed the base branch from master to develop June 20, 2018 20:36
@pkarw pkarw merged commit da3006c into vuestorefront:develop Jun 22, 2018
@DavidRouyer DavidRouyer deleted the webpack-config branch August 1, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants