Feature/1426 #1452
Merged
Feature/1426 #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Am I right that currently you’re downloading all the cms content to the state and then get the specific page block from it? That’s good I think it would be best if the Vue-storefont-api could use the elasticsearchjs to index this content while downloading it from Magento to elasticsearch index, page / block entities By having this lazy loaded elastic cache the app can provide the search in cms feature as a next step Could you take care of that? |
Collaborator
Author
|
@pkarw yup, for now the cms data are stored in state. I'll take care of love it with elasticsearch but can't handle it this week for sure. I'll do it asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1426
this API in vue-storefront-api repo needed:
vuestorefront/vue-storefront-api#74
and SnowdogApps/magento2-cms-api version 1.1.0 need to be installed in Magento 2 instance