Price tiers. #1625
Merged
Price tiers. #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
requested changes
Aug 23, 2018
Collaborator
pkarw
left a comment
pkarw
left a comment
There was a problem hiding this comment.
Please clean up search.js from the content specific parameters - we should operate on groupId and groupToken on the higher level; this helper should be content agnostic
core/store/lib/search.js
Outdated
| elasticQuery.body.groupToken = rootStore.state.user.groupToken | ||
| } | ||
|
|
||
| /* use only for cache */ |
Collaborator
There was a problem hiding this comment.
This shouldn’t be here - search.js should not now about any specific content of the query. Please move it one level higher - on the hashing level
Add user groupToken to state, cache result with groupToken.
pkarw
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user groupToken to state, cache result with groupToken.