Issue #1572. Fix breadcrumbs on product page. Generate breadcrumbs ba… #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se on category with lowest level
pkarw
reviewed
Sep 20, 2018
|
|
||
| for (let cat of catList) { | ||
| const catPath = cat.path | ||
| if (catPath && catPath.includes(rootCat.path) && (catPath.split('/').length > catForBreadcrumbs.path.split('/').length)) { |
Collaborator
There was a problem hiding this comment.
The path field was not required before and if somebody is using for example M1 connector can have problem with this field being empty.
Can we easily add a fallback to the previous behavior - modified just by the way you’re selecting the root category?
So when the path is not set let’s generate breadcrumbs the previous way with parents
Collaborator
|
@afirlejczyk could You take care of this backward compatibility issue next week? |
pkarw
approved these changes
Sep 26, 2018
Collaborator
|
I've fixed it on my own :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate breadcrumbs base on category with lowest level.
Related issues
#1572
Contribution and curently important rules acceptance