Fix for #1762 #1764
Merged
Fix for #1762 #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cart loader bypass feature is there because we’re posting orders to Magento asynchronously - it may happen that directly after playing an order, the Magento’s user still have the same quote id and after browsing thru VS Store old items will be restored to the shopping cart. Now You can disable this behaviour by setting `config.cart.bypassCartLoaderForAuthorizedUsers=false`. I’ve also moved the place when this bypass timestamp is set (to directly after order is being created)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cart loader bypass feature is there because we’re posting orders to Magento asynchronously - it may happen that directly after playing an order, the Magento’s user still have the same quote id and after browsing thru VS Store old items will be restored to the shopping cart. Now You can disable this behaviour by setting
config.cart.bypassCartLoaderForAuthorizedUsers=false. I’ve also moved the place when this bypass timestamp is set (to directly after order is being created)Related issues
#1762
Contribution and currently important rules acceptance