-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add catalog filters, Fix breadcrumb issues #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add catalog filters, Fix breadcrumb issues #3691
Conversation
|
@andrzejewsky @grimasod Test instructions / suggestion needed here :) |
|
@ArturDivante so, first of all:
You can also, text me on slack if you want more details |
|
Here's one way to test the new config options. To prepare the catalog:
To test
|
|
@grimasod 😮 nice explanation and test scenario! @alinadivante / @ArturDivante Can you have a look? |
|
@ArturDivante Please take a look at this and test it in your free time:) |
|
@andrzejewsky I see this PR didn't make it into 1.11.0-rc2. Will there be an rc3? Thanks |
|
@grimasod We want to merge it in |
|
Hey @grimasod seems like everything works fine, but one thing that must be changed here... Could you add a new options that you've introduced to the |
…y settings in default.json
|
Hi @andrzejewsky no problem, added to default.json :) No code changes. |
andrzejewsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 simple comments @grimasod they are related to your changes i default.json now you don't have to check parameters because they always exist
…ault.json Co-Authored-By: Patryk Andrzejewski <vox3r69@gmail.com>
…use in default.json Co-Authored-By: Patryk Andrzejewski <vox3r69@gmail.com>
Related issues
Short description and why it's useful
Fixes breadcrumbs for products that are in multiple categories, in different branches of the category tree
Uses breadcrumbs module store, so breadcrumb categories are only calculated once
Adds an optional filter of breadcrumb categories to local.json
Also adds pre-defined category search query filters in local.json that are applied to every query. This removes the need to define more and more parameters for category/list calls, but still allows parameters to override the pre-defined filters. It also means the currently hardcoded platform-specific parameters, like "is_active" and "product_count", could be deprecated.
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and currently important rules acceptance