Skip to content

Conversation

@krskibin
Copy link
Collaborator

@krskibin krskibin commented Oct 10, 2019

Related issues

closes #3440

Short description and why it's useful

Some users report a problem with building VSF due to lack of python2, g++ and make. So, these dependencies should be placed in the Dockerfile.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@krskibin krskibin changed the base branch from develop to release/v1.11 October 10, 2019 09:53
@krskibin krskibin marked this pull request as ready for review October 10, 2019 09:54
@andrzejewsky andrzejewsky self-requested a review October 10, 2019 09:54
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkoszutowski Please check this one out regarding our cloud infrastructure reqs; I’m not sure if we faced problems similar to #3444 and if it’s generally a good idea to have a fixed dependencies of g++ and python (?)

@krskibin isnt it like an issue related to just some envs where sharp (?) library needed to be built from sources / no packages available? If so maybe we should rather create a separate docker file for those systems (like WSL, maybe MacOSX?)

I’m not a devops expert though 🤷‍♂️:-)

@lukeromanowicz
Copy link
Contributor

These dependencies are required in some scenarios to install node-sass.

@andrzejewsky
Copy link
Contributor

@pkarw I even did some research about that problem and it seems quite common. I asked @krskibin to figure out whether there is a workaround (eg. via update dependences or something like that ) instead of calling just RUN, and as it turned out, calling RUN with command that install everything that is necessary is the easiest way to solve that problem. There is even information about that: https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md#node-gyp-alpine

@pkarw
Copy link
Collaborator

pkarw commented Oct 10, 2019

OK, I'm not an expert here. Please do apply the best practices in here @andrzejewsky

@andrzejewsky andrzejewsky merged commit 024e040 into vuestorefront:release/v1.11 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants