Skip to content

Conversation

@ResuBaka
Copy link
Collaborator

Related issues

closes #

Short description and why it's useful

Fixed graphql sort option and cms_blocks.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@andrzejewsky andrzejewsky self-requested a review October 15, 2019 19:48
@andrzejewsky andrzejewsky requested a review from patzick October 15, 2019 19:48
As _score needs to be default DESC and not ASC we need to check if the sort key is _score or not.
@ResuBaka
Copy link
Collaborator Author

Added a small improvement to the sort fix. Here was still not the full fix in it where the key needs to be checked for _score as this needs to be default to DESC and not ASC.

@pkarw pkarw merged commit 726a0e7 into vuestorefront:release/v1.11 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants