Defense against incomplete config in ssr renderer #3774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
approved these changes
Nov 5, 2019
Collaborator
pkarw
left a comment
pkarw
left a comment
There was a problem hiding this comment.
Not sure if it's necessary and required defense but in the end it's such a small change that's fine with me
Contributor
Author
|
@pkarw It comes down to project's policy - personally I'd wrap every user's (developer's) input like this. |
Contributor
|
@oskar1233 same here, please create this PR from |
Precisely in getFieldsToFilter method.
oskar1233
force-pushed
the
feature/ssr-renderer-defense
branch
from
16e8ac2 to
b3d22e2
Compare
Contributor
Author
|
@andrzejewsky Sorted here as well. |
andrzejewsky
approved these changes
Nov 6, 2019
Contributor
|
@oskar1233 you have errors to fix, look into the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adds some defensive config fetching in SSR renderer. Protects against incomplete config, e.g. after update.
Relates to
develop(test version).No upgrade steps required.