Keep git after yarn install

[ddanier]

Related issues

none

Short description and why it's useful

We need to keep git after the initial install inside the Dockerfile, as there is an additional "yarn install" inside vue-storefront.sh. This would fail without having git around.

Screenshots of visual changes before/after (if there are any)

none

Which environment this relates to

no idea what would be fitting here

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)
• I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

• I read and followed contribution rules

[andrzejewsky]

@ddanier Could you please change base to the release/v1.11?

[ddanier]

@andrzejewsky Seriously? The patch is about changing 2 lines, you could easily do that yourself. In addition it actually is your product and you should care about putting releases out - that's what I figure release/v1.11 is for.

In addition:
Your contribution rules state to use "develop" and it is probably easy to just cherry-pick the change over to the release. So please don't alienate people fixing your bugs and following this rules.

That said:
I am willing to give you a (paid) introduction about how a good git workflow should look like if you want to… ;-)

[pkarw]

Wow :) @ddanier that was harsh. You could change the branches in less time than writing this comment :)

ps. Please don't forget that this product is >MIT licensed<. It's totally free. We spent more than 2 years of work by the Core team (which @andrzejewsky is part of) to give you this product for free. Just to - you know - remind that we don't need to put the rude comments

ps2. Thanks for the feedback on contributing notes; we'll update it. Thanks!

[ddanier]

@pkarw Sorry, I was probably in a mood writing this ;-)

I always get the feeling, that free software tends to drive people away by forcing additional useless work on them. As you said: Writing that comment did actually take longer than doing the rebase. As did writing the first comment in question by @andrzejewsky. It really is just a change of two lines in the code. You actually wouldn't even have needed a pull request for this - I have gone through this additional work to make things easier for you, trying to follow your contribution notes as close as I could. You know I have done that fix in my free time, too.

So keep up the good work and thanks for your feedback. I think you have done a great job here!

[pkarw]

Thanks :) Peace 🙌

[ddanier]

Thank you all!