Skip to content

Conversation

@grimasod
Copy link
Contributor

@grimasod grimasod commented Dec 5, 2019

Related issues

closes #

Short description and why it's useful

The Category Set Products mutation adds full product data to nonReactiveState and saves only the SKU in state.products. When adding more products (for example when onBottomScroll is triggered on a Category page) the Category Add Products mutation must do the same.

Also removed an unnecessary cloneDeep operation - there's no need to deep copy a 1-dimensional array returned my the map function

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@andrzejewsky andrzejewsky changed the base branch from release/v1.11 to develop December 5, 2019 11:39
@andrzejewsky andrzejewsky self-requested a review December 5, 2019 17:50
@andrzejewsky andrzejewsky merged commit c1c52bf into vuestorefront:develop Dec 5, 2019
@grimasod grimasod deleted the bugfix/fix-category-add-products branch January 6, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants