-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Breadcrumbs Filter and Component fixes #3887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs Filter and Component fixes #3887
Conversation
…into bugfix/fix-breadcrumbs-filter # Conflicts: # CHANGELOG.md
|
Description updated. This PR now also fixes an issue with the Breadcrumbs component. |
|
@grimasod I don't fully understand the second issue. When you pass an empty array to the routes you will get eg. |
|
@andrzejewsky Until now, it has always been In the example you give, it would make sense if we had just browsed the Tops category, but not in all cases. For example, if we added some bags to the Compare list and then looked at women's tops without adding any. On the Compare page, we would get The other cases too:
Should be
|
|
I guess we need @patzick comment on this one |
|
@grimasod ok I see, I could even reproduce it |
Related issues
closes #
Short description and why it's useful
Fixes multiple Breadcrumb issues that are new in v1.11
A specific example is Magento's "Default Category". Often every product belongs to this category, but it may not be wanted in the breadcrumbs. It can be excluded by turning off "Include in menu" and adding
"breadcrumbFilterFields": { "include_in_menu": true }to the config. This fix is required for this behavior to work correctly.Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and currently important rules acceptance