Skip to content

Save shipping to cache storage when property updates #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Save shipping to cache storage when property updates #3894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
854587f
Save shipping to cache storage when property updates
Dec 12, 2019
6ce7298
Changelog update for 3894
Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add to cart from Wishlist and Product listing for simple products - @Dnd-Dboy, @dz3n (#2637)
- Add global Category and Breadcrumb filters, defined in local.json - @grimasod (#3691)
- Add constant which conditions the number of products loading per page - @AdKamil (#3630)
- Added price filtering key as config - @roywcm
- Added price filtering key as config - @roywcm

### Fixed
- Always close zoom overlay after changing product - @psmyrek (#3818)
Expand All @@ -41,6 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686)
- Improve the readability of 'getShippingDetails()' and 'updateDetails()' method of UserShippingDetails component - @adityasharma7 (#3770)
- Keep git after yarn install in dockerfile - @ddanier (#3826)
- Update the Storage Manager shipping details cache immediately when then Vuex checkout store is updated - @grimasod (#3894)

## [1.11.0-rc.2] - 2019.10.31

Expand Down
2 changes: 1 addition & 1 deletion core/modules/checkout/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const CheckoutModule: StorefrontModule = function ({store}) {
}

if (
type.endsWith(types.CHECKOUT_SAVE_SHIPPING_DETAILS)
type.endsWith(types.CHECKOUT_SAVE_SHIPPING_DETAILS) || type.endsWith(types.CHECKOUT_UPDATE_PROP_VALUE)
) {
StorageManager.get('checkout').setItem('shipping-details', state.checkout.shippingDetails).catch((reason) => {
console.error(reason) // it doesn't work on SSR
Expand Down