Bugfix/attribute filter #3964
Merged
Bugfix/attribute filter #3964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which resulted the additional network call each time product query was about to execute
andrzejewsky
force-pushed
the
bugfix/attribute_filter
branch
from
7afa6f8 to
b6c3d7a
Compare
andrzejewsky
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
After the refactoring - the attributes filter wasn't filtering the attributes properly: which resulted in the additional network call each time the product query was about to execute.
Actually - it was rather querying ElasticSearch for the nonfiltered attributes like
configurable_children.price. The filter is removing the multipart attributes (that never existed in elastic search).So maybe it's not generating the additional network call but in the end, it's querying Elastic for the attributes that should be switched off (the next time they're not used for a query as they're added to the blacklist I guess)