bugfix - revert init filters

[gibkigonzo]

Short Description and Why It's Useful

On init load https://test.storefrontcloud.io/women/women-20 filters are missing on SSR so we get price without format.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

• Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
• RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
• Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)
• I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[pkarw]

@gibkigonzo it will cause memory leak - there is a known issue with Vue.mixins and Vue.filters and memory leaks

if we're to move it out this once helper then it must be executed ONLY in CSR mode - however not sure if it won't cause another side effects blinking or CSR/SSR DOM mismatch

Reference: vuejs/vue#5089

[gibkigonzo]

I just reverted this from 1.10.5. It's wierd problem because if we call those initialization in once then filters exist on Vue prototype but there are not triggered in template. And it happens only in ssr (It's ok in csr). And same is with mixin. They are not triggered in ssr. I will try to investigate it further

[gibkigonzo]

@pkarw Problem is that we add filters once and then in price filter we import currentStoreView which returns storeView from cached module (from first request). So I've added storeView to global in SSR, we will get always newest storeView in ssr. Also removed this helper https://github.com/DivanteLtd/vue-storefront/pull/3968/files#diff-c2effc5bdc3d0e591b453db20306e6d9L82 because it's not needed anymore.

[gibkigonzo]

Or we could pass storeView to price filter (and date filter). Filters would be more pure, but we would have to pass this every time in template product.price | price(currentStoreView())

[pkarw]

That makes sense. I'd opt for both solutions:

• use the global for the storeView placeholder to keep b.c.
• use it as a filter parameter (with default value pointing to this global) - to be used in the new themes

[andrzejewsky]

what about client-side? there is no global?

[gibkigonzo]

there is no global on client-side, I could use window, but I think we can stay with same behavior as it was for client

[gibkigonzo]

it is in next line const clientStoreView = get(rootStore, 'state.storeView', undefined)

[andrzejewsky]

@gibkigonzo one comment left. Is it ready?

[gibkigonzo]

@pkarw @andrzejewsky I've applied suggestion