Comparison of bundled products in the productsEquals.ts #4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Merged
Contributor
|
@gk-daniel I've tried to rebase your branch again but the second time - I've got permission denied - here is your PR: #4013 |
Contributor
|
@gk-daniel and when it comes to your changes - make sense you just allow compare by sku when checksums are not equals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#4004
closes #
Short Description and Why It's Useful
In the absence of these attributes from the product, as a result, returning false can lead to the problem of working with adding the product to the card, as happened in our store. This decision corrects this situation.