Skip to content

Conversation

@ResuBaka
Copy link
Collaborator

Short Description and Why It's Useful

Currently the http code from a response is not cached and it should as 404 pages can be cached to. The 404 is only an example of status codes that may be cached or are wanted to be cached.

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@pkarw pkarw requested a review from andrzejewsky January 23, 2020 08:20
@pkarw
Copy link
Collaborator

pkarw commented Jan 23, 2020

To be ported into VSF 1.11 as well

@ResuBaka
Copy link
Collaborator Author

Do you guys want to add the changelog entry or should I do it?

@ResuBaka ResuBaka changed the base branch from master to hotfix/v1.11.1 January 23, 2020 09:52
@ResuBaka ResuBaka changed the base branch from hotfix/v1.11.1 to master January 23, 2020 09:52
@pkarw
Copy link
Collaborator

pkarw commented Jan 23, 2020

Yes, please

@ResuBaka ResuBaka changed the base branch from master to hotfix/v1.11.1 January 23, 2020 09:58
@ResuBaka
Copy link
Collaborator Author

Done @pkarw

And changed to merge into the hotfix branch. Most of the changes you can see in here are coming from the master as my branch is based on the master.

@andrzejewsky
Copy link
Contributor

@ResuBaka I think you have to rebase with the source branch, or cherry-pick your commits

@ResuBaka ResuBaka force-pushed the fix/add-respons-code-to-caching-data branch from 1d3ca9e to 4c2e3d1 Compare January 25, 2020 13:54
@ResuBaka
Copy link
Collaborator Author

I have fixed it :)

Force push + cherry-pick = 🔥

@andrzejewsky andrzejewsky merged commit 272eec7 into vuestorefront:hotfix/v1.11.1 Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants