Skip to content

Conversation

@Michal-Dziedzinski
Copy link
Collaborator

Related Issues

closes #3704

Short Description and Why It's Useful

Replace microdata to json-ld which is the recommended by Google.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@gibkigonzo
Copy link
Contributor

Hey 😄 wdyt about moving all of those functions to separate file as helpers?
We could expose there:

  • export function reviewJsonLd({review})
  • export function productJsonLd({product, configuration, attributes, storeView})

and rest keep as local functions:

  • function getMaterials(material)

also I think we can now remove structuredData and just get availability in helper 🤔

@andrzejewsky
Copy link
Contributor

@Michal-Dziedzinski Looks really good, one thing - did you test it with some validator ? eg: https://json-ld.org/playground/ (if document generated by product page is correct)

@Michal-Dziedzinski
Copy link
Collaborator Author

@Michal-Dziedzinski Looks really good, one thing - did you test it with some validator ? eg: https://json-ld.org/playground/ (if document generated by product page is correct)

no, but after checking it turned out that I have to add a few fields to the object with reviews, so I added them :)

@andrzejewsky
Copy link
Contributor

@Michal-Dziedzinski please resolve conflict here and it will be ready for merge ;)

@Michal-Dziedzinski
Copy link
Collaborator Author

@andrzejewsky resolved ;)

@andrzejewsky andrzejewsky merged commit 4341cea into vuestorefront:develop Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants