-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace microdata to json-ld #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace microdata to json-ld #4018
Conversation
|
Hey 😄 wdyt about moving all of those functions to separate file as helpers?
and rest keep as local functions:
also I think we can now remove |
|
@Michal-Dziedzinski Looks really good, one thing - did you test it with some validator ? eg: https://json-ld.org/playground/ (if document generated by product page is correct) |
no, but after checking it turned out that I have to add a few fields to the object with reviews, so I added them :) |
|
@Michal-Dziedzinski please resolve conflict here and it will be ready for merge ;) |
|
@andrzejewsky resolved ;) |
Related Issues
closes #3704
Short Description and Why It's Useful
Replace microdata to json-ld which is the recommended by Google.
Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance