Skip to content

Conversation

@1070rik
Copy link
Contributor

@1070rik 1070rik commented Jan 29, 2020

Related Issues

Short Description and Why It's Useful

When upgrading from v1.10 to v1.11 we're told to remove the Product.js mixin because the functionality from this file is moved to the events.ts file. However, Product.js used to notify the user if they selected an invalid product configuration and this wasn't copied to the event.ts file. I don't know if this wasn't copied on purpose or if it was just forgotten but I think it's way better to still notify a user if a configuration is not possible.

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@andrzejewsky andrzejewsky merged commit 8b57ac5 into vuestorefront:develop Jan 30, 2020
@1070rik 1070rik deleted the bugfix/wrong-attribute-error branch January 30, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants