Skip to content

sku attribute is missing on compare page #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2020
Merged

sku attribute is missing on compare page #4036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f113a6
allow sku in compare list
Jan 30, 2020
d6047a6
update changelog
Jan 30, 2020
37109d6
Merge branch 'hotfix/v1.11.1' into bugfix/sku-missing-in-compare
andrzejewsky Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed `Processing order...` modal closing too early - @grimasod (#4021)
- Keep registered payment methods after `syncTotals` - @grimasod (#4020)
- Added status code to the cache content and use it in cache response - @resubaka (#4014)
- Fixed sku attribute is missing on compare page - @gibkigonzo (#4036)
- Fixed z-index for aside in compare list - @gibkigonzo (#4037)
- Disable checking max quantity when manage stock is set to false - @gibkigonzo (#4038)

Expand Down
3 changes: 0 additions & 3 deletions core/modules/catalog/helpers/filterAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ export default function filterAttributes ({
codesList: any
}) {
return filterValues.filter(fv => {
if (config.entities.product.standardSystemFields.indexOf(fv) >= 0) {
return false
}
if (fv.indexOf('.') >= 0) {
return false
}
Expand Down