-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Feature/price formatting #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrzejewsky
merged 10 commits into
vuestorefront:develop
from
EndPositive:feature/price-formatting
Feb 16, 2020
Merged
Feature/price formatting #4061
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
23543da
Add price formatting
EndPositive 4d19673
Change let to const in price formatting
EndPositive 42540f1
Update Changelog and Upgrade notes
EndPositive 55f459e
Add module to yarn.lock
EndPositive c9c04c6
Remove priceformatting.js, introduce fractionDigits and bring back pr…
EndPositive 7a5203c
Update setup.md and types.ts.
EndPositive b1765a1
Fix undefined value when not using currencyDecimal/Group.
EndPositive 0aa9816
Merge branch 'develop' into feature/price-formatting
andrzejewsky bafa1ae
Replace null by empty string.
EndPositive 68b8c23
Merge branch 'feature/price-formatting' of https://github.com/EndPosi…
EndPositive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your changes, looks much better but... why not just changing this line? I mean... I think it's totally enough to move just these two options
minimumFractionDigitsandmaximumFractionDigitsto the config file and you don't anything else... ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because as said #3553, they also wanted to be able to change the separators.