Skip to content

Conversation

@gibkigonzo
Copy link
Contributor

@gibkigonzo gibkigonzo commented Feb 7, 2020

Related Issues

closes #4053

Short Description and Why It's Useful

There are no prices because render-list doesn't have configurable_children data. So we clear prices for children (clearPricesBeforePlatformSync), then we fetch render-list, update prices for parent and at the end we return child (variant) as product. So child has price:null.

I've checked magento docs and probably there is no option to add configurable_children to render-list data.

So only solution is to add children skus to parent skus. But we can't fetch all of them because we will have to fetch 500+ skus :/

We can change order in processCategoryProducts, so in that case parent will be replaced already by child (variant), but it's probably huge change. This require some tests and comments.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please jsut disable the pricesSyncOver process in the default.json

@pkarw pkarw requested a review from andrzejewsky February 7, 2020 14:31
@pkarw pkarw added this to the 1.11.3 milestone Mar 5, 2020
@gibkigonzo gibkigonzo changed the base branch from hotfix/v1.11.2 to hotfix/v1.11.3 April 7, 2020 09:02
@gibkigonzo gibkigonzo changed the title [WIP] bugfix/4053 configure products before price update Apr 7, 2020
@gibkigonzo gibkigonzo requested a review from pkarw April 7, 2020 13:25
@gibkigonzo gibkigonzo linked an issue Apr 7, 2020 that may be closed by this pull request
2 tasks
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! just one check here: please check editing cart and refreshing totals (sync cart) as well

@gibkigonzo gibkigonzo merged commit 271781c into vuestorefront:hotfix/v1.11.3 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct prices sync with Magento not working

3 participants