Skip to content

Conversation

@Michal-Dziedzinski
Copy link
Collaborator

Related Issues

closes #4064

Short Description and Why It's Useful

GTM order placement event didn't trigger when user was placing order as a guest. If orders are not fetched, data to GTM event are from store.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@andrzejewsky andrzejewsky merged commit 0ae0ef3 into vuestorefront:hotfix/v1.11.2 Feb 19, 2020
Copy link
Contributor

@simonmaass simonmaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipping and tax are wrongly switched

Copy link
Contributor

@simonmaass simonmaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzejewsky @Michal-Dziedzinski tax and shipping are switched

@andrzejewsky
Copy link
Contributor

@Michal-Dziedzinski can you fix that?

@Michal-Dziedzinski Michal-Dziedzinski mentioned this pull request Feb 21, 2020
6 tasks
@Michal-Dziedzinski
Copy link
Collaborator Author

@andrzejewsky sure, #4117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants