add fixes for 'productChecksum', 'productsEquals', lazy cart creation, qty for all product types #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 27, 2020 09:26
…wait for cart sync
…products types. Remove 'checksum' when editing product. Remove and add coupon when user login.
gibkigonzo
added
the
QA - Ready for tests
gibkigonzo
requested review from
Michal-Dziedzinski,
andrzejewsky,
mdanilowicz and
pkarw
pkarw
approved these changes
Feb 27, 2020
andrzejewsky
approved these changes
Feb 27, 2020
| } | ||
|
|
||
| // 'checksum' check | ||
| const getChecksum = (product: CartItem) => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| const getChecksum = (product: CartItem) => { | |
| const getChecksum = (product: CartItem) => product.checksum ? product.checksum : productChecksum(product) |
mayby shorter form, wdyt? :)
| const getServerItemId = (product: CartItem): string | number => | ||
| product.server_item_id || product.item_id | ||
|
|
||
| const isServerIdsEquals = (product1: CartItem, product2: CartItem): boolean => { |
Collaborator
There was a problem hiding this comment.
Why types are removed?
|
|
||
| // 'sku' check | ||
| const isSkuEqual = (product1: CartItem, product2: CartItem): boolean => | ||
| String(product1.sku) === String(product2.sku) |
Collaborator
There was a problem hiding this comment.
Can be sku another type than string?
|
|
||
| // 'sku' check | ||
| const isSkuEqual = (product1: CartItem, product2: CartItem): boolean => | ||
| String(product1.sku) === String(product2.sku) |
Collaborator
There was a problem hiding this comment.
Can be sku another type than string?
| case 'checksum': { | ||
| return isChecksumEquals | ||
| } | ||
| case 'sku': { |
Collaborator
There was a problem hiding this comment.
shouldn't it be remove if it is the same as default?
Collaborator
|
@gibkigonzo
|
alinadivante
added
QA rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #4123, #4118, #4104
onload.Short Description and Why It's Useful
Screenshots of Visual Changes before/after (if There Are Any)
Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance