Skip to content

Conversation

@gibkigonzo
Copy link
Contributor

Short Description and Why It's Useful

After we update dependencies there is some different behavior with vue in ssr. We used no-ssr and v-if (changed on mounted) for product-gallery-carousel (where is vue-carousel) and this was ok before we update dependencies. After update it throws error. So I've changed to lazy load only vue-carousel.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@gibkigonzo gibkigonzo requested review from patzick and pkarw March 6, 2020 13:18
@pkarw pkarw merged commit de11733 into vuestorefront:hotfix/v1.11.2 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants