Skip to content

Conversation

@haelbichalex
Copy link
Contributor

Related Issues

closes #

Short Description and Why It's Useful

Since .every returns true for an empty array, the cart/isVirtualCart getter returned true. In my opinion it should be false for an empty cart.

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add the CHANGELOG entry please

@haelbichalex haelbichalex force-pushed the bugfix/fix-is-virtual-cart-calculation branch from 6d303ef to 900c358 Compare March 16, 2020 12:54
@haelbichalex
Copy link
Contributor Author

Done 👍

@pkarw pkarw added this to the 1.12.0-rc1 milestone Mar 17, 2020
@pkarw pkarw merged commit 7c73989 into vuestorefront:develop Mar 17, 2020
@haelbichalex haelbichalex deleted the bugfix/fix-is-virtual-cart-calculation branch March 17, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants