Fixes bug that caused addToCart action not to display messages to user #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
gibkigonzo
reviewed
Mar 23, 2020
The very first time something was added to the cart, the user did not see any messages
("Added to cart", "n items need to be backordered", etc). These were displayed only
on the following times. This commit fixes it so that the messages are displayed also
on the very first action call.
See vuestorefront#4185
juho-jaakkola
force-pushed
the
bugfix/4185
branch
from
671aaa4 to
10559a8
Compare
gibkigonzo
approved these changes
Mar 23, 2020
juho-jaakkola
commented
Mar 23, 2020
| const syncDiffLog = await dispatch('sync', { forceClientState: true }) | ||
|
|
||
| if (!syncDiffLog.isEmpty()) { | ||
| diffLog.merge(syncDiffLog) |
Author
There was a problem hiding this comment.
Make sure that all these .merge() calls make sense, as I'm not that familiar with the cart implementation.
pkarw
approved these changes
Mar 23, 2020
andrzejewsky
approved these changes
Mar 28, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #4185
Short Description and Why It's Useful
The very first time something was added to the cart, the user did not see any messages
("Added to cart", "n items need to be backordered", etc). These were displayed only
on the following times. This commit fixes it so that the messages are displayed also
on the very first action call.
Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance