Skip to content

Conversation

@cewald
Copy link
Contributor

@cewald cewald commented Apr 11, 2020

Related Issues

There are usecases where the property values are either strings or numbers.
By consolidate the type, using toString we can prevent that no configurable items are found because the option property-types doesn't match.

Short Description and Why It's Useful

Can cause missing product options.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

cewald added 2 commits April 11, 2020 09:09
* There are usecase where the property values are either strings or numbers
* By consolidate the type, using `toString` we can prevent that no configurable item is found because the option property type doesn't match
@cewald cewald closed this Apr 11, 2020
@cewald cewald reopened this Apr 11, 2020
@gibkigonzo gibkigonzo merged commit 661fd25 into vuestorefront:develop Apr 11, 2020
@cewald cewald deleted the bugfix/get-configuration-match-level-type-fix branch April 11, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants