Skip to content

Use LRU as object contructor based on newest changes in module #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2020
Merged

Use LRU as object contructor based on newest changes in module #4248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3cae98
adjust changes to lru bc
Apr 15, 2020
b35bc20
update changelog
Apr 15, 2020
29e7b6d
Merge branch 'hotfix/v1.11.3' of github.com:DivanteLtd/vue-storefront…
Apr 15, 2020
e1c77ad
Merge branch 'hotfix/v1.11.4' into bugfix/lru-cache
May 5, 2020
01e5ddd
Merge branch 'hotfix/v1.11.4' into bugfix/lru-cache
May 7, 2020
dbb7232
Merge branch 'hotfix/v1.11.4' into bugfix/lru-cache
May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.11.4] - UNRELEASED

### Added


### Changed / Improved


### Fixed

- Use LRU as object contructor based on newest changes in module - @gibkigonzo (#4242)


## [1.11.3] - 2020.04.27

### Changed / Improved
Expand Down
2 changes: 1 addition & 1 deletion core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"lean-he": "^2.0.0",
"localforage": "^1.7.2",
"lodash-es": "^4.17",
"lru-cache": "^4.0.1",
"lru-cache": "^5.1.1",
"query-string": "^6.2.0",
"redis-tag-cache": "^1.2.1",
"remove-accents": "^0.4.2",
Expand Down
3 changes: 2 additions & 1 deletion core/scripts/utils/ssr-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ const config = require('config')
const minify = require('html-minifier').minify

function createRenderer (bundle, clientManifest, template) {
const LRU = require('lru-cache')
// https://github.com/vuejs/vue/blob/dev/packages/vue-server-renderer/README.md#why-use-bundlerenderer
return require('vue-server-renderer').createBundleRenderer(bundle, {
clientManifest,
// runInNewContext: false,
cache: require('lru-cache')({
cache: new LRU({
max: 1000,
maxAge: 1000 * 60 * 15
})
Expand Down