Skip to content

Bugfix for reactivity of current_configuration in populateProductConfigurationAsync #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Bugfix for reactivity of current_configuration in populateProductConfigurationAsync #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b599483
Bugfix for reactivity of `current_configuration` in `populateProductC…
Apr 19, 2020
1319067
Update CHANGELOG.md
Apr 19, 2020
9e5ed44
Improve state update in `populateProductConfigurationAsync`
Apr 22, 2020
10f1d04
Merge branch 'develop' into bugfix/reactivity-in-product-core-state
Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Use `setProductGallery` in `product/setCurrent` to use logic of the action - @cewald (#4153)
- Use same data format in getConfigurationMatchLevel - @gibkigonzo (#4208)
- removed possible memory leak in ssr - @resubaka (#4247)
- Bugfix for reactivity of `current_configuration` in `populateProductConfigurationAsync` - @cewald (#4258)
- Bugfix for build exception in Node v13.13+ - @cewald (#4249)

### Changed / Improved
Expand Down
4 changes: 2 additions & 2 deletions core/modules/catalog/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import Vue from 'vue'
import EventBus from '@vue-storefront/core/compatibility/plugins/event-bus'
import rootStore from '@vue-storefront/core/store'
import flattenDeep from 'lodash-es/flattenDeep'
import omit from 'lodash-es/omit'
import remove from 'lodash-es/remove'
import toString from 'lodash-es/toString'
import union from 'lodash-es/union'
import isObject from 'lodash-es/union'
// TODO: Remove this dependency
import { optionLabel } from './optionLabel'
import i18n from '@vue-storefront/i18n'
Expand Down Expand Up @@ -474,7 +474,7 @@ export function populateProductConfigurationAsync (context, { product, selectedV
id: selectedOption.value,
label: selectedOption.label ? selectedOption.label : /* if not set - find by attribute */optionLabel(context.rootState.attribute, { attributeKey: selectedOption.attribute_code, searchBy: 'code', optionId: selectedOption.value })
}
context.state.current_configuration[attribute_code] = confVal
Vue.set(context.state.current_configuration, attribute_code, confVal)
}
if (config.cart.setConfigurableProductOptions) {
const productOption = setConfigurableProductOptionsAsync(context, { product: product, configuration: context.state.current_configuration }) // set the custom options
Expand Down