Skip to content

Conversation

@SDLyu
Copy link
Contributor

@SDLyu SDLyu commented May 5, 2020

Related Issues

closes #

Short Description and Why It's Useful

options[attributeCode] get undefined if key color or size not existed in options.

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@vercel
Copy link

vercel bot commented May 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/vue-storefront/5zve8bc9l
✅ Preview: https://vue-storefront-git-fork-sdlyu-bugfix-undefinedoptions.shopware-pwa.now.sh

@vercel vercel bot temporarily deployed to preview May 5, 2020 15:54 Inactive
@gibkigonzo gibkigonzo added this to the 1.11.4 milestone May 7, 2020
@gibkigonzo gibkigonzo self-requested a review May 7, 2020 07:51
@vercel vercel bot temporarily deployed to preview May 7, 2020 07:52 Inactive
@gibkigonzo gibkigonzo merged commit 9704c8a into vuestorefront:hotfix/v1.11.4 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants