Skip to content

Conversation

@juho-jaakkola
Copy link

Related Issues

closes #4376

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/vue-storefront/5zve8bc9l
✅ Preview: https://vue-storefront-git-fork-juho-jaakkola-bugfix-4376-multistore.shopware-pwa.now.sh

@vercel vercel bot temporarily deployed to preview May 12, 2020 07:17 Inactive
@gibkigonzo
Copy link
Contributor

@juho-jaakkola thanks for this, please update changelog

@juho-jaakkola
Copy link
Author

@gibkigonzo I'm not completely sure what to put into the changelog.

Do you think the text in the commit message would be enough?

@juho-jaakkola juho-jaakkola force-pushed the bugfix/4376-multistore branch from 835f8cc to 3e8add5 Compare May 12, 2020 08:46
@vercel vercel bot temporarily deployed to preview May 12, 2020 08:46 Inactive
@juho-jaakkola
Copy link
Author

  • Marked the properties in core/lib/types.ts as optional
  • Updated the CHANGELOG

@gibkigonzo gibkigonzo linked an issue May 13, 2020 that may be closed by this pull request
5 tasks
@gibkigonzo gibkigonzo merged commit b406da4 into vuestorefront:hotfix/v1.11.4 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parts of code not checking for multistore

2 participants