Skip to content

fix: type in multistore #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix: type in multistore #7050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fe3310
fix: type in multistore
WojtekTheWebDev Feb 16, 2024
426ae0a
fix: get could also be undefined
WojtekTheWebDev Feb 16, 2024
2fc6003
update changeset
WojtekTheWebDev Feb 16, 2024
d4e8930
apply review feedback
WojtekTheWebDev Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-drinks-tickle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vue-storefront/multistore": patch
---

[FIXED] Type issue in multistore package. Cache control `set` method returns `any` type and `get` returns `StoreConfig | undefined`. Also, `MiddlewareConfiguration` type has been removed as it is no longer necessary.
16 changes: 2 additions & 14 deletions packages/multistore/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ export interface CacheManager {
/**
* Gets a store configuration from cache storage based on the `key` value.
*/
get(key: string): StoreConfig;
get(key: string): StoreConfig | undefined;

/**
* Sets a store configuration in the cache storage with identifier equals `key` value.
*/
set(key: string, value: StoreConfig): StoreConfig;
set(key: string, value: StoreConfig): unknown;
}

/**
Expand Down Expand Up @@ -43,18 +43,6 @@ export interface MultistoreExtensionMethods {
}) => Record<string, StoreConfig>;
}

export interface MiddlewareConfiguration {
/**
* Multistore configuration.
*/
multistore: MultistoreExtensionMethods;

/**
* Other configration entries, that are not being used by the multistore extension.
*/
[key: string]: any;
}

/**
* Parameters for updateConfig utility function.
*/
Expand Down