Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/modern-comics-impress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vue-storefront/middleware": patch
---

**[FIXED]** type of `defaultErrorHandler`
8 changes: 2 additions & 6 deletions packages/middleware/src/errors/defaultErrorHandler.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import { getAgnosticStatusCode } from "../helpers";
import type { Integration } from "../types";
import type { ErrorHandler } from "../types";

/**
* Default error handler for the middleware
*/
export const defaultErrorHandler: Integration["errorHandler"] = (
error,
_req,
res
) => {
export const defaultErrorHandler: ErrorHandler = (error, _req, res) => {
const status = getAgnosticStatusCode(error);
res.status(status);
if (status < 500) {
Expand Down
12 changes: 7 additions & 5 deletions packages/middleware/src/types/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ export interface ApiClientExtension<API = any, CONTEXT = any, CONFIG = any> {
) => ApiClientExtensionHooks;
}

export type ErrorHandler = (
error: unknown,
req: AlokaiRequest,
res: AlokaiResponse
) => void;

export interface Integration<
CONFIG extends TObject = any,
API extends ApiMethods = any,
Expand Down Expand Up @@ -162,11 +168,7 @@ export interface Integration<
* };
* ```
*/
errorHandler?: (
error: unknown,
req: AlokaiRequest,
res: AlokaiResponse
) => void;
errorHandler?: ErrorHandler;
}

export interface RequestParams {
Expand Down
Loading