Skip to content

Conversation

@lorenaramonda
Copy link
Collaborator

Notice: pay attention that this may disable color change effects on hovering some element, especially those that use primary color variables as now they're the same in both statuses:

primary: (
default: map-get($colors, matterhorn),
hover: map-get($colors, matterhorn)
),

matterhorn is #4F4F4F

(this is the right PR, I hope! thanks @pkarw for the patience!)

@pkarw
Copy link
Collaborator

pkarw commented Mar 30, 2018

@StasiekDivante could you check the hovers - as Lori they disappear after this change and I’m not sure if that’s expected effect?

@StasiekDivante
Copy link
Collaborator

@lorenaramonda that's one good point, haven't noticed that

By color replacement I meant replacement in font colors - headers, link etc
Thanks for staying attentive!

@pkarw
Copy link
Collaborator

pkarw commented Mar 31, 2018

@lorenaramonda could you just adjust this change to not cover the elements that do have some hover effect?

@lorenaramonda
Copy link
Collaborator Author

Yes @pkarw sure. I'll have a check!

@lorenaramonda
Copy link
Collaborator Author

Now it should have been replaced where needed. The change also affected the .notification.info class in src/themes/catalog/components/core/Notification.vue. Please, check that this is the desiderata.

@pkarw
Copy link
Collaborator

pkarw commented Apr 6, 2018

Thanks!

@pkarw pkarw merged commit 2b8d707 into vuestorefront:develop Apr 7, 2018
@lorenaramonda lorenaramonda deleted the feature/956-colors-fix branch May 3, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants