IKEv2 Proto Init #468
Merged
IKEv2 Proto Init #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also added an Active param to the Session struct and changed the logic to RemoveSession(s) functions to set this value to false instead of deleting it
lobsterjerusalem
requested review from
ccondon-vc,
j-shomo,
spac3yspace,
terrorbyte and
wvu
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the foundational IKEv2 protocol implementation with basic structs and helper functions. The implementation provides the groundwork for IKEv2-related exploits rather than a complete protocol implementation.
- Adds comprehensive IKEv2 constants and type definitions for payloads, exchanges, transforms, and algorithms
- Implements packet packing functions for various IKEv2 payload types
- Provides basic cryptographic operations and connection management for IKEv2 clients
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| protocol/ikev2/types.go | Defines IKEv2 constants, enums, and core data structures for clients, crypto operations, proposals, and transforms |
| protocol/ikev2/packs.go | Implements packet packing functions for IKEv2 payloads including nonce, vendor ID, notify, key exchange, and security association |
| protocol/ikev2/ikev2_test.go | Contains unit tests for vendor ID, security association, and notify packet packing functions |
| protocol/ikev2/ikev2.go | Provides utility functions, Diffie-Hellman key generation, crypto initialization, and UDP connection management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terrorbyte
reviewed
Oct 30, 2025
Collaborator
terrorbyte
left a comment
terrorbyte
left a comment
There was a problem hiding this comment.
I do think the biggest ask is the type change.
terrorbyte
approved these changes
Oct 30, 2025
Collaborator
terrorbyte
left a comment
terrorbyte
left a comment
There was a problem hiding this comment.
Just give the doc comments one more look for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic structs and helper functions for ikev2. Not an entire proto, but a foundation.