Update chromedriver to default to 2.30#285
Merged
stephenash merged 2 commits intowebdriverio:masterfrom Jun 12, 2017
Merged
Conversation
UsainBloot
force-pushed
the
chromedriver-default-2.30
branch
2 times, most recently
from
d1ff8ba to
5ca5f5a
Compare
UsainBloot
force-pushed
the
chromedriver-default-2.30
branch
from
5ca5f5a to
2088e7e
Compare
|
Yes, please review/merge this! 👍 😄 🚀 |
gauravrajput44
approved these changes
Jun 9, 2017
gauravrajput44
added a commit
to gauravrajput44/wdio-selenium-standalone-service
that referenced
this pull request
Jun 9, 2017
This update is needed to resolve chrome to open in maximize mode while runnig in headless mode. This commit is dependent on below commit webdriverio/selenium-standalone#285 Once above commit gets merged selenium standalone would be updated to have version 6.5.0 and will point to use chrome driver 2.30.
|
Can someone merge it? |
Contributor
Author
|
Have either of you had a chance to look at this yet? I'm eager to get it defaulted so I can start fully using chrome headless, especially now its part of the stable release. |
Contributor
|
@UsainBloot Thanks for the PR. Everything looks good so I'll get this merged in and released shortly. As a reminder, this library provides clients the ability to choose their own driver version so that you are not so reliant on one of our contributors to update the default versions used. The details on how to use that are outlined in the README. |
|
Please merge it ASAP. My PR (webdriverio-boneyard/wdio-selenium-standalone-service#25) is dependent on this merge. |
christian-bromann
pushed a commit
to webdriverio-boneyard/wdio-selenium-standalone-service
that referenced
this pull request
Jun 12, 2017
This update is needed to resolve chrome to open in maximize mode while runnig in headless mode. This commit is dependent on below commit webdriverio/selenium-standalone#285 Once above commit gets merged selenium standalone would be updated to have version 6.5.0 and will point to use chrome driver 2.30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium released chromedriver 2.30 today
Defaulting chromedriver to 2.30 will fix issues when trying to resize the browser when using Chrome headless.
The following APIs have been moved from being an extension to being part of the Dev Tools
https://chromedevtools.github.io/devtools-protocol/tot/Browser/#method-setWindowBounds
As chrome headless does not allow the use of extensions then resizing the browser fails with any version lower than 2.30.
Binaries available here:
https://chromedriver.storage.googleapis.com/index.html?path=2.30/