T7012 OSPFv2 integration tests fixes

[omnom62]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T7012

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

$ ansible-test units --docker -v --python 3.12

• generated xml file: /root/ansible_collections/vyos/vyos/tests/output/junit/python3.12-controller-units.xml -
  ============================= 345 passed in 10.05s =============================

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.3.8
• 1.4-rolling-202201010100
• 1.5-rolling-202502120007

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[gaige]

Appears to be missing at least one file update in parsed. A few other requests, otherwise looking good.

[omnom62]

Added pre- and post-tasks script to add target dependencies

[gaige]

Can you update the PR template here? The test versions seem out of date, there's no link to the story.

[gaige]

Tests look good now for me. However, please verify that pre-commit is running on your system and then manually re-run it (per slack) to update wrapping, etc. Also update the PR information in the template .

[omnom62]

Can you update the PR template here? The test versions seem out of date, there's no link to the story.

done

[gaige]

One concern here, but otherwise good to go. Tests succeed reliably on my systems.

[gaige]

Tests pass, looks good.

[dmbaturin]

My only note is that VyOS 1.3 is EOL now and all its mentions can be removed/omitted in the future, I think.

[gaige]

My only note is that VyOS 1.3 is EOL now and all its mentions can be removed/omitted in the future, I think.

Yeah, the plan (detailed in the README.md) is to remove support for 1.3.8 in 7.0.x. Considering that 6.0.0 has much more test coverage, we want to get it out supporting 1.3.8, so that there's a stable release for folks to move from 1.3.8 to 1.4.x+ (since that would mean they can gather and send configs.