Skip to content

Commit 51f6f65

Browse files
IsaDCmcking65
IsaDC
and
mcking65
authored
Refactor Actions Menu Button Example Using element.focus() Test Plan to V2 Test Format (pull #1122)
* Update APG example and test plan to v2 format * Update tests csv, references.csv and assertions.csv with feedback * Correct example title in references.csv * Fix setupScript * Remove commands.csv v1 * Correct test plan title in references.csv * Correct example URL * Add quick nav of to voiceover_macos-commands.csv * Change priority to may for role i=menuitem in tests 4 and 5 * Remove extra comma from instructions for the first two tests. * Add missing references * Based on issue 1143, remove posinset and setsize assertions from insert+up for request information about a menu item * Based on issue 1143, remove posinset and setsize assertions from insert+up in test for request information about a menu item * Fix URL for menu button with activeDescendant example in references --------- Co-authored-by: Matt King <a11yThinker@gmail.com>
1 parent 243505e commit 51f6f65

25 files changed

+1386
-526
lines changed

‎tests/menu-button-actions/data/assertions.csv‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
assertionId,priority,assertionStatement,assertionPhrase,refIds
2+
nameActions,1,"Name of the menu button, 'Actions', is conveyed","convey name of the menu button, 'Actions'",button
3+
nameMenuActions,3,"Name of the menu, 'Actions', is conveyed","convey name of the menu, 'Actions'",menu aria-labelledby
4+
nameFocusedItemAction1,1,"Name of the focused item, 'Action 1', is conveyed","convey name of the focused item, 'Action 1'",menuitem
5+
nameFocusedItemAction2,1,"Name of the focused item, 'Action 2', is conveyed","convey name of the focused item, 'Action 2'",menuitem
6+
nameFocusedItemAction4,1,"Name of the focused item, 'Action 4', is conveyed","convey name of the focused item, 'Action 4'",menuitem
7+
numberItemsMenu4,2,"Number of items in the menu,'(4', is conveyed","convey number of items in the menu, '4'",aria-setsize
8+
roleFocusedItemMenuItem,2,"Role of the focused item, 'menu item', is conveyed","convey role of the focused item, 'menu item'",menuitem
9+
roleMenu,3,Role 'menu' is conveyed,convey role 'menu',menu
10+
roleMenuButton,1,Role 'menu button' is conveyed,convey role 'menu button',button aria-haspopup
11+
stateCollapsed,1,State 'collapsed' is conveyed,convey state 'collapsed',aria-expanded
12+
interactionModeEnabled,2,Screen reader switched from reading mode to interaction mode|{screenReader} switched from {readingMode} to {interactionMode},switch from reading mode to interaction mode|switch from {readingMode} to {interactionMode},
13+
positionFocusedItemMenu1,2,"Position of the focused item in the menu, '1', is conveyed","convey position of the focused item in the menu, '1'",aria-posinset
14+
positionFocusedItemMenu2,2,"Position of the focused item in the menu, '2', is conveyed","convey position of the focused item in the menu, '2'",aria-posinset
15+
positionFocusedItemMenu4,2,"Position of the focused item in the menu, '4', is conveyed","convey position of the focused item in the menu, '4'",aria-posinset

‎tests/menu-button-actions/data/commands.csv‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

‎tests/menu-button-actions/data/jaws-commands.csv‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
testId,command,settings,assertionExceptions,presentationNumber
2+
navForwardsToMenuButton,b,virtualCursor,,1
3+
navForwardsToMenuButton,f,virtualCursor,,1.1
4+
navForwardsToMenuButton,tab,virtualCursor,2:interactionModeEnabled,1.2
5+
navForwardsToMenuButton,down,virtualCursor,,1.3
6+
navBackToMenuButton,shift+b,virtualCursor,,2
7+
navBackToMenuButton,shift+f,virtualCursor,,2.1
8+
navBackToMenuButton,shift+tab,virtualCursor,2:interactionModeEnabled,2.2
9+
navBackToMenuButton,up,virtualCursor,,2.3
10+
navForwardsToMenuButton,tab,pcCursor,,3
11+
navBackToMenuButton,shift+tab,pcCursor,,4
12+
reqInfoAboutMenuButton,ins+tab,virtualCursor,,7
13+
reqInfoAboutMenuButton,ins+up,virtualCursor,,7.1
14+
reqInfoAboutMenuButton,ins+tab,pcCursor,,8
15+
reqInfoAboutMenuButton,ins+up,pcCursor,,8.1
16+
openMenu,space,virtualCursor,2:interactionModeEnabled,10
17+
openMenu,enter,virtualCursor,2:interactionModeEnabled,10.1
18+
openMenu,space,pcCursor,,11
19+
openMenu,enter,pcCursor,,11.1
20+
openMenu,down,pcCursor,,11.2
21+
openMenuToLastItem,up,pcCursor,,13
22+
reqInfoAboutMenuItem,ins+tab,virtualCursor,,15
23+
reqInfoAboutMenuItem,ins+up,virtualCursor,0:positionFocusedItemMenu1 0:numberItemsMenu4 0:nameMenuActions 0:roleMenu,15.1
24+
reqInfoAboutMenuItem,ins+tab,pcCursor,,15.2
25+
reqInfoAboutMenuItem,ins+up,pcCursor,0:positionFocusedItemMenu1 0:numberItemsMenu4 0:nameMenuActions 0:roleMenu,15.3
26+
navToFirstItemMenu,home,pcCursor,,17
27+
navToFirstItemMenu,down,pcCursor,,17.1
28+
navToLastItemMenu,end,pcCursor,,19
29+
navToLastItemMenu,up,pcCursor,,19.1
30+
navToItemMenuByTypingCharacter,a,pcCursor,,21
31+
activateMenuItem,enter,pcCursor,,23
32+
closeMenu,esc,pcCursor,,25

‎tests/menu-button-actions/data/nvda-commands.csv‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
testId,command,settings,assertionExceptions,presentationNumber
2+
navForwardsToMenuButton,b,browseMode,,1
3+
navForwardsToMenuButton,f,browseMode,,1.1
4+
navForwardsToMenuButton,tab,browseMode,2:interactionModeEnabled,1.2
5+
navForwardsToMenuButton,down,browseMode,,1.3
6+
navBackToMenuButton,shift+b,browseMode,,2
7+
navBackToMenuButton,shift+f,browseMode,,2.1
8+
navBackToMenuButton,shift+tab,browseMode,2:interactionModeEnabled,2.2
9+
navBackToMenuButton,up,browseMode,,2.3
10+
navForwardsToMenuButton,tab,focusMode,,3
11+
navBackToMenuButton,shift+tab,focusMode,,4
12+
reqInfoAboutMenuButton,ins+tab,browseMode,,7
13+
reqInfoAboutMenuButton,ins+up,browseMode,,7.1
14+
reqInfoAboutMenuButton,ins+tab,focusMode,,8
15+
reqInfoAboutMenuButton,ins+up,focusMode,,8.1
16+
openMenu,space,browseMode,2:interactionModeEnabled,10
17+
openMenu,enter,browseMode,2:interactionModeEnabled,10.1
18+
openMenu,space,focusMode,,11
19+
openMenu,enter,focusMode,,11.1
20+
openMenu,down,focusMode,,11.2
21+
openMenuToLastItem,up,focusMode,,13
22+
reqInfoAboutMenuItem,ins+tab,browseMode,,15
23+
reqInfoAboutMenuItem,ins+up,browseMode,0:positionFocusedItemMenu1 0:numberItemsMenu4 0:nameMenuActions 0:roleMenu,15.1
24+
reqInfoAboutMenuItem,ins+tab,focusMode,,15.2
25+
reqInfoAboutMenuItem,ins+up,focusMode,0:positionFocusedItemMenu1 0:numberItemsMenu4 0:nameMenuActions 0:roleMenu,15.3
26+
navToFirstItemMenu,home,focusMode,,17
27+
navToFirstItemMenu,down,focusMode,,17.1
28+
navToLastItemMenu,end,focusMode,,19
29+
navToLastItemMenu,up,focusMode,,19.1
30+
navToItemMenuByTypingCharacter,a,focusMode,,21
31+
activateMenuItem,enter,focusMode,,23
32+
closeMenu,esc,focusMode,,25

‎tests/menu-button-actions/data/references.csv‎

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
refId,value
2-
author,Isabel Del Castillo
3-
authorEmail,isa.delcastillo5@gmail.com
4-
title,Action Menu Button Example Using element.focus()
5-
reference,reference/2021-1-14_12348/menu-button-actions.html
6-
designPattern,https://w3c.github.io/aria-practices/#menubutton
7-
example,https://w3c.github.io/aria-practices/examples/menu-button/menu-button-actions.html
8-
menu,https://w3c.github.io/aria/#menu
9-
menuitem,https://w3c.github.io/aria/#menuitem
10-
aria-haspopup,https://w3c.github.io/aria/#aria-haspopup
11-
aria-controls,https://w3c.github.io/aria/#aria-controls
12-
aria-labelledby,https://w3c.github.io/aria/#aria-labelledby
13-
aria-expanded,https://w3c.github.io/aria/#aria-expanded
1+
refId,type,value,linkText
2+
author,metadata,Isabel Del Castillo,
3+
authorEmail,metadata,isa.delcastillo5@gmail.com,
4+
title,metadata,Action Menu Button Example Using element.focus(),
5+
reference,metadata,reference/2024-8-28_1295/menu-button-actions.html,Test Case Page for Action Menu Button Example Using element.focus()
6+
designPattern,metadata,https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/,APG Pattern: Menu Button
7+
example,metadata,https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions-active-descendant/,APG Example: Actions Menu Button Using element.focus()
8+
menu,aria,menu,menu
9+
menuitem,aria,menuitem,menuitem
10+
aria-haspopup,aria,aria-haspopup,aria-haspopup
11+
aria-controls,aria,aria-controls,aria-controls
12+
aria-labelledby,aria,aria-labelledby,aria-labelledby
13+
aria-expanded,aria,aria-expanded,aria-expanded
14+
aria-posinset,aria,aria-posinset,aria-posinset
15+
aria-setsize,aria,aria-setsize,aria-setsize
16+
button,htmlAam,button,button

‎tests/menu-button-actions/data/scripts.csv‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
setupScript,setupScriptDescription
2+
openMenuAndSetFocusToFirstItem,"opens the menu, and sets focus on 'Action 1'"
3+
openMenuAndSetFocusToLastItem,"opens the menu, and sets focus on 'Action 4'"
4+
setFocusAfterMenuButton,sets focus on a link after the menu button
5+
setFocusBeforeMenuButton,sets focus on a link before the menu button
6+
setFocusOnMenuButton,sets focus on the menu button

0 commit comments

Comments
 (0)