Re-order CDDL definitions so that Command / Message are first #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first rule in a CDDL document defines the entry point to validate a CBOR data item. The CDDL of each module started with `Extensible`, which essentially made any CBOR data item valid. This update makes `Command` and `Message` the first CDDL rules in each module (as done in WebDriver BiDi), and defines `Extensible` is a single block common to both the remote end and local end definitions.
Member
Author
|
For the CI failure, see #84 ;) |
jugglinmike
approved these changes
Dec 18, 2024
Contributor
jugglinmike
left a comment
jugglinmike
left a comment
There was a problem hiding this comment.
Great! Thank you, François!
github-actions bot
added a commit
that referenced
this pull request
Dec 18, 2024
SHA: 7cb6e57 Reason: push, by jugglinmike Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first rule in a CDDL document defines the entry point to validate a CBOR data item. The CDDL of each module started with
Extensible, which essentially made any CBOR data item valid.This update makes
CommandandMessagethe first CDDL rules in each module (as done in WebDriver BiDi), and definesExtensibleis a single block common to both the remote end and local end definitions.Preview | Diff