Skip to content

Consider returning a promise from saveImpression #180

@apasel422

Description

@apasel422

The difference in shape of the exception handling here makes me concerned that we won't be able to retrofit a Promise return for saveImpression. Should I be concerned?

Originally posted by @martinthomson in #178 (review)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions