Clear-Site-Data integration #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This monkey-patches the Clear-Site-Data spec, which monkey-patches fetch. 🙊 Closes #125.
apasel422
requested changes
May 16, 2025
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
May 19, 2025
|
|
||
| The [:Clear-Site-Data:] field [[CLEAR-SITE-DATA]] | ||
| gives sites the ability to remove state maintained by a [=user agent=]. | ||
| The \``"impressions"`\` type is added to the list of recognized types, |
There was a problem hiding this comment.
Just checking: Are we intentionally rendering the backticks here?
There was a problem hiding this comment.
Apparently, that is house style. That is what you get with [:Clear-Site-Data:] as well:
(I think that it's gross, but who am I to suggest that?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This monkey-patches the Clear-Site-Data spec, which monkey-patches fetch. 🙊
Closes #125.
Preview | Diff