Skip to content

Exclude expired impressions from common matching logic #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Exclude expired impressions from common matching logic #186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0c3733
Make stored-impression lifetime field a duration
apasel422 May 28, 2025
97e4b38
Exclude expired impressions from common matching logic
apasel422 May 28, 2025
a972958
Update api.bs
apasel422 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ The [=impression store=] is a [=set=] of [=impression|impressions=]:
or `undefined` if the API was invoked by the [=impression site=].
<dfn>Conversion Sites</dfn>: The [=set=] of [=conversion sites=] that were passed to <a>saveImpression()</a>.
<dfn>Timestamp</dfn>: The time at which <a>saveImpression()</a> was called.
<dfn>Lifetime</dfn>: The number of days an [=/impression=] remains eligible for attribution, either from the call to <a>saveImpression()</a>, or a [=/user agent=]-defined limit.
<dfn>Lifetime</dfn>: The [=duration=] an [=/impression=] remains eligible for attribution, either from the call to <a>saveImpression()</a>, or a [=/user agent=]-defined limit.
<dfn>Histogram Index</dfn>: The histogram index passed to <a>saveImpression()</a>.
</pre>
</div>
Expand Down Expand Up @@ -1414,6 +1414,9 @@ To perform <dfn>common matching logic</dfn>, given
1. [=set/iterate|For each=] |impression| in the [=impression store=] for the |epoch|:
<!-- TODO: Clarify "for the |epoch|" -->

1. If |now| is after |impression|'s [=impression/timestamp=] plus |impression|'s
[=impression/lifetime=], [=iteration/continue=].

1. If |now| - |lookbackDays| is after |impression|'s [=impression/timestamp=],
[=iteration/continue=].

Expand Down
Loading