Skip to content

Remove lookback-based early return from common matching logic #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

Remove lookback-based early return from common matching logic #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions api.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,11 +1693,6 @@ To perform <dfn>common matching logic</dfn>, given

1. Let |matching| be an [=set/is empty|empty=] [=set=].

1. Let |earliestEpoch| be the result of calling [=get the current epoch=],
passing |topLevelSite| and (|now| − |options|' [=validated conversion options/lookback=]).

1. If |earliestEpoch| is greater than |epoch|, return |matching|.

1. [=set/iterate|For each=] |impression| in the [=impression store=]:

1. Let |impressionEpoch| be the result of calling [=get the current epoch=],
Expand Down
8 changes: 0 additions & 8 deletions impl/src/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,6 @@ export class Backend {
): Set<Impression> {
const matching = new Set<Impression>();

const earliestEpoch = this.#getCurrentEpoch(
topLevelSite,
now.subtract(lookback),
);
if (earliestEpoch > epoch) {
return matching;
}

for (const impression of this.#impressions) {
const impressionEpoch = this.#getCurrentEpoch(
topLevelSite,
Expand Down