Refactor note about controller property usage. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
David-Chadwick,
KDean-Dolphin,
TallTed,
brentzundel,
decentralgabe,
dlongley,
dmitrizagidulin,
iherman,
jandrieu,
longpd and
selfissued
David-Chadwick
approved these changes
Sep 2, 2024
decentralgabe
approved these changes
Sep 2, 2024
| are authorized to perform certain actions associated with the resource with | ||
| which it is associated. To ensure explicit security guarantees, the | ||
| [=controller=] of a [=verification method=] cannot be inferred from the | ||
| [=controller document=]. It is necessary to explicitly express the identifier of |
There was a problem hiding this comment.
is this statement asserting that if a verification method does not have a controller property one cannot assume the controller is the controller of the document itself? that does not seem correct
There was a problem hiding this comment.
Rather, I think it says that the lack of a controller property, and any assumption that might be made stemming from this lack, is an inherent security issue.
selfissued
approved these changes
Sep 2, 2024
dlongley
approved these changes
Sep 3, 2024
msporny
force-pushed
the
msporny-vm-controllers
branch
from
a57d66c to
bce3f0d
Compare
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #57 by refactoring the note about how the controller property is used.
Preview | Diff