Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Conversation

@cvrebert
Copy link
Member

@syncbot
Copy link
Collaborator

syncbot commented Jul 12, 2015

Automatic validation checks of commit 2c5b879 discovered the following problem:

In css-transitions-1/events-007.html:

  • Missing anchor for specification link to css-transitions-2.

@syncbot
Copy link
Collaborator

syncbot commented Jul 12, 2015

Automatic validation checks of commit 4da3ba2 passed.

@cvrebert
Copy link
Member Author

CC: @dbaron (as an Editor of the relevant specs)

@cvrebert
Copy link
Member Author

CC: @tabatkins (as the one who proposed the relevant behavior clarification)

@dbaron
Copy link
Member

dbaron commented Jul 24, 2015

Is this two copies of the same test? If so, why? Seems better to just have one copy, tagged for level 1 of transitions (i.e., css3-transitions).

@syncbot
Copy link
Collaborator

syncbot commented Jul 24, 2015

Automatic validation checks of commit 398a470 passed.

@cvrebert
Copy link
Member Author

@dbaron I wasn't sure which level the spec clarification applied to. I've now removed the css-transitions-2 copy.

@dbaron
Copy link
Member

dbaron commented Jul 24, 2015

Did you test the test locally to see that it behaves as you expect?

I'm a little confused since part of the test uses a variable called "div" and part uses a variable called "e", which looks like it's meant to be the same thing. I'd think that running the JS would throw an exception when trying to access e.className when e is undefined, although maybe I'm missing something.

@syncbot
Copy link
Collaborator

syncbot commented Jul 24, 2015

Automatic validation checks of commit 5abb23e passed.

@syncbot
Copy link
Collaborator

syncbot commented Jul 24, 2015

Automatic validation checks of commit 14c0fb8 passed.

@cvrebert
Copy link
Member Author

@dbaron No, you're right. This is what I get for trying to rename a variable late in the game. Fixed that and re-tested locally; it works.
Convenient live copy of the test: http://jsbin.com/hivira/edit?html,output

dbaron added a commit that referenced this pull request Jul 24, 2015
Add test that transitionend is not fired after element is made display:none
@dbaron dbaron merged commit 9461969 into w3c:master Jul 24, 2015
@cvrebert cvrebert deleted the transitionend-sadness branch July 24, 2015 02:37
@cvrebert
Copy link
Member Author

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants