-
Notifications
You must be signed in to change notification settings - Fork 38
Issue 537 UI widgets #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Issue 537 UI widgets #572
Conversation
Note that accessibility review will probably advise us to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just made some small suggestions to use the respec css class for examples.
Co-authored-by: Ieben Smessaert <smessie@users.noreply.github.com> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Edmond Chuc <37032744+edmondchuc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line breaks in the ReSpec source (aside from those that are about keeping the lines below some maximum width) that are manually inserted to help comprehension of that source are usually if not always worth propagating to the rendered .html
(via <br>
).
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Another point in favour of SVG is maintainability. SVG is a portable, editable format. PNG is not editable. The downside is the possible extra initial work for SVG. |
This PR adds the widgets from datashapes.org. The namespace was adapted, and other minor changes were made to align it with the other SHACL specifications.
The selection of widgets and the details in the widget should be handled in a separate PR. This is an initial starting point so that other PRs can refer to widgets.
dash:applicableToClass and dash:rootClass was kept as there is no matching SHACL property. The dash namespaces should be easier to notice when we work on the details.
Closes #537